Skip to content

T27: Reset Password API Routes #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fahadakhan2 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

T27: Reset Password API Routes #18

fahadakhan2 wants to merge 1 commit into from

Conversation

@fahadakhan2
Copy link
Contributor

@fahadakhan2 fahadakhan2 commented Jul 2, 2024 •
edited
Loading

Description:

  • Added a route '/reset-password' to our parent route /api/auth
  • Created placeholder handler function as that will be created in a different task

Happy case:
Screenshot 2024-07-03 at 3 53 28 PM

Error case:
Screenshot 2024-07-03 at 3 54 09 PM

@fahadakhan2 fahadakhan2 marked this pull request as ready for review July 2, 2024 21:30
@fahadakhan2 fahadakhan2 self-assigned this Jul 3, 2024
@fahadakhan2 fahadakhan2 added the enhancement New feature or request label Jul 3, 2024
justinpchen94
justinpchen94 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@justinpchen94 justinpchen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just check the error messages

backend/routes/resetPassword.ts
const resetPasswordSchema: Schema = {
newPassword: {
isString: true,
errorMessage: 'Password must be a string',
Copy link
Collaborator

@justinpchen94 justinpchen94 Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this error message only for the isString check? i think the docs suggest that this error must be a level deeper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinpchen94 justinpchen94 justinpchen94 approved these changes

@chinkevin25 chinkevin25 Awaiting requested review from chinkevin25

@kdata12 kdata12 Awaiting requested review from kdata12

Assignees

@fahadakhan2 fahadakhan2

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fahadakhan2 @justinpchen94