Skip to content

Conversation

@jgoelen
Copy link

@jgoelen jgoelen commented Sep 20, 2016

This pull request adds a directive that controls the _source field of every hit. It can be used to optimize the size of the search hits in case you have documents with large fields.

Example usage:

<input type="hidden" eui-enabled="true" eui-query="ui.composed" eui-source="['foo','bar']"/>

Copy link

@Jipos Jipos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your pull requests seems to contain some unneede whitespace changes.

}

export interface IIndexViewModel {
export interface IIndexViewModel {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this whitespace added?

<li ng-if="indexVM.page <= 1" class="disabled"><a href="">Previous</a></li>\
<li ng-if="indexVM.page > 1"><a href="" ng-click="indexVM.page=indexVM.page - 1">Previous</a></li>\
<li ng-if="indexVM.pageCount <= indexVM.page" class="disabled"><a href="">Next</a></li>\
<li ng-if="indexVM.pageCount > indexVM.page"><a href="" ng-click="indexVM.page=indexVM.page + 1">Next</a></li>\
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only changes in this template are whitespace changes? Why was this necessary?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is generated by the grunt build.

<span ng-if="!filter.enabled"><a href="" ng-click="filter.enabled=true">{{bucket.key}} <span class="muted">({{bucket.doc_count}})</span></a></span>\
<span ng-if="filter.enabled">{{bucket.key}} <a href="" ng-click="filter.enabled=false" class="facet-remove">x</a></span>\
</label>\
</li>\
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only changes in this template are whitespace changes? Why was this necessary?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is generated by the grunt build.

@YousefED
Copy link
Owner

Thanks for the work guys.

At the moment I'm unable to commit any time to ElasticUI, and I think it could benefit from:

  • Migrating away from the deprecated Fullscale elasticjs library
  • Increased support for Elasticsearch 2
  • Moving to angular 2 (probably fits better with the ElasticUI class system + Typescript)

Let alone the open issues raised in this repo. If any of you are interested in working more on this project, I'm open to making you a maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants