-
Notifications
You must be signed in to change notification settings - Fork 130
Add directive to control the _source attribute of a search request #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Jipos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your pull requests seems to contain some unneede whitespace changes.
src/controllers/IIndexScope.ts
Outdated
| } | ||
|
|
||
| export interface IIndexViewModel { | ||
| export interface IIndexViewModel { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this whitespace added?
| <li ng-if="indexVM.page <= 1" class="disabled"><a href="">Previous</a></li>\ | ||
| <li ng-if="indexVM.page > 1"><a href="" ng-click="indexVM.page=indexVM.page - 1">Previous</a></li>\ | ||
| <li ng-if="indexVM.pageCount <= indexVM.page" class="disabled"><a href="">Next</a></li>\ | ||
| <li ng-if="indexVM.pageCount > indexVM.page"><a href="" ng-click="indexVM.page=indexVM.page + 1">Next</a></li>\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only changes in this template are whitespace changes? Why was this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is generated by the grunt build.
| <span ng-if="!filter.enabled"><a href="" ng-click="filter.enabled=true">{{bucket.key}} <span class="muted">({{bucket.doc_count}})</span></a></span>\ | ||
| <span ng-if="filter.enabled">{{bucket.key}} <a href="" ng-click="filter.enabled=false" class="facet-remove">x</a></span>\ | ||
| </label>\ | ||
| </li>\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only changes in this template are whitespace changes? Why was this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is generated by the grunt build.
|
Thanks for the work guys. At the moment I'm unable to commit any time to ElasticUI, and I think it could benefit from:
Let alone the open issues raised in this repo. If any of you are interested in working more on this project, I'm open to making you a maintainer. |
This pull request adds a directive that controls the _source field of every hit. It can be used to optimize the size of the search hits in case you have documents with large fields.
Example usage: