Stream bounds-checking changes ported from GZDoom#1158
Merged
coelckers merged 2 commits intoZDoom:masterfrom Jul 17, 2025
Merged
Stream bounds-checking changes ported from GZDoom#1158coelckers merged 2 commits intoZDoom:masterfrom
coelckers merged 2 commits intoZDoom:masterfrom
Conversation
Minimal changes have been made to Raze's code to make it function with the updated source/common files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports over the changes of ZDoom/gzdoom#3198 and ZDoom/gzdoom#3199 to Raze.
All changes in
source/common/are copied exactly from GZDoom. I copied the relevant files from GZDoom'ssrc/common/over, then I usedgit restore -pto remove some unrelated changes to those files. (GZDoom's master branch has a refactor of some networking code touching other parts of some of these same files and I'm not trying to port those changes over in this PR. I do not believe this PR will add any complications to any future effort to port those changes over from GZDoom.)These changes fix a similar buffer overflow here as in GZDoom, and it also fixes a similar issue where the
NCMD_MULTIflag is handled.