Skip to content

Added core midi support to ZMusic#84

Merged
coelckers merged 1 commit intoZDoom:masterfrom
johncurley:coremidi
Nov 23, 2025
Merged

Added core midi support to ZMusic#84
coelckers merged 1 commit intoZDoom:masterfrom
johncurley:coremidi

Conversation

@johncurley
Copy link
Contributor

Core midi support has been added to ZMusic for request ZDoom/gzdoom#3266

Tested on Apple's IAC virtual midi driver.

@coelckers
Copy link
Member

I do not have a Mac so I have no means to test it.
So the only option is to merge it as it is and wait for reports.

@coelckers coelckers merged commit b151968 into ZDoom:master Nov 23, 2025
8 checks passed
@Cacodemon345
Copy link
Contributor

This PR does not seem to have actually implemented any sort of proper timer usage whatsoever.

Doesn't CoreMIDI have the ability to schedule MIDI events in the future?

@johncurley
Copy link
Contributor Author

Ah, I see. It's in send immediately mode and doesn't have event scheduling. I'll see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants