disable debug.log by default + add config option to enable it#100
Merged
RhettCreighton merged 2 commits intoZclassicCommunity:masterfrom Jan 4, 2026
Merged
disable debug.log by default + add config option to enable it#100RhettCreighton merged 2 commits intoZclassicCommunity:masterfrom
RhettCreighton merged 2 commits intoZclassicCommunity:masterfrom
Conversation
This insecure default was inherited from zcash. the debug log may contain sensitive transaction metadata. it should only be used for debugging, not for production, therefore debug logs now are not created unless explicitly enabled.
since we now disable debug.log by default, add option to enable debug.log
RhettCreighton
approved these changes
Jan 4, 2026
RhettCreighton
left a comment
RhettCreighton
left a comment
There was a problem hiding this comment.
Code Review: APPROVED
Security improvement - well justified:
-
util.cpp: Changes
fPrintToDebugLogdefault fromtruetofalse- correct behavior for a privacy-focused coin -
init.cpp: Adds
-debuglogfileoption with clear help text indicating it's disabled by default for privacy reasons
The fix is minimal and focused. Users who need debug logging for development/troubleshooting can explicitly enable it with -debuglogfile=1.
Addresses issue #97. Ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
debug.logby default.This insecure default was inherited from zcash.
the debug log may contain sensitive transaction metadata. it should only be used for debugging, not for production, therefore debug logs now are not created unless explicitly enabled.
-debuglogfileconfig option since it is now disabled by defaultfixes #97
secure shredding will be implemented next