Disable the Alert System inherited from ZEC/BTC#104
Open
hairetikos wants to merge 1 commit intoZclassicCommunity:masterfrom
Open
Disable the Alert System inherited from ZEC/BTC#104hairetikos wants to merge 1 commit intoZclassicCommunity:masterfrom
Alert System inherited from ZEC/BTC#104hairetikos wants to merge 1 commit intoZclassicCommunity:masterfrom
Conversation
i actually removed this back in 2016 (see hairetikos/zclassic-103-master@df7549d and other commits), but it seems it got reinserted when ZCL re-forked the newer ZEC sapling upgrade back then to fix the Sprout security issues. this is the quickest way to neuter it without having to touch the rest of the code, we fully purge the unused code later on when also removing things like Onion V2 code (as we have Onion V3 now) note: the `ProcessAlert` return of `false` means the P2P handler in `main.cpp` will call `Misbehaving` for every alert message received. this is actually desireable... nodes trying to abuse the alert system will eventually get banned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
security issue: i actually removed this back in 2016 (see hairetikos/zclassic-103-master@df7549d and other commits), but it seems it got reinserted when ZCL re-forked the newer ZEC
Saplingupgrade back then to fix theSproutsecurity issues.this is the quickest way to disable the Alert System without having to touch the rest of the code:
(just return/return false immediately)
we can fully purge the unused code later on when also removing things like Onion V2 code (as we have Onion V3 now), and compiling with LTO can already remove dead code too.
note: the
ProcessAlertreturn offalsemeans the P2P handler inmain.cppwill callMisbehavingfor every alert message received. this is actually desirable... nodes trying to abuse the alert system will eventually get banned.