Skip to content

Comments

Bitcoin Class Fix and Minor addition to SQL#4

Open
DevScarabyte wants to merge 1 commit intoZen00:masterfrom
DevScarabyte:master
Open

Bitcoin Class Fix and Minor addition to SQL#4
DevScarabyte wants to merge 1 commit intoZen00:masterfrom
DevScarabyte:master

Conversation

@DevScarabyte
Copy link

Great work on the project here are a few fixes i had to apply to get the project to work correctly

@Zen00
Copy link
Owner

Zen00 commented Mar 15, 2014

Just wondering why you added that line to the database, should already be hard coded to use the proper theme anyways.

@DevScarabyte
Copy link
Author

added it there so a user (who doesn't know any php) will know what the theme is and if they made a theme easily change. it's minor not even needed

@Zen00
Copy link
Owner

Zen00 commented Mar 16, 2014

Yeah, the theme already sets properly in the PHP, additional database muddling should be avoided if possible.

Thanks for the bitcoin class fix though!

@DevScarabyte
Copy link
Author

Also got a suggestion for adding additional database handlers when you use php5-mysqlnd it messes with projects that require a php5-mysql strictly. I was working on adding a $config['db']['type'] to config but would need changing ALOT of stuff and a big hassle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants