Bitcoin Class Fix and Minor addition to SQL#4
Open
DevScarabyte wants to merge 1 commit intoZen00:masterfrom
Open
Bitcoin Class Fix and Minor addition to SQL#4DevScarabyte wants to merge 1 commit intoZen00:masterfrom
DevScarabyte wants to merge 1 commit intoZen00:masterfrom
Conversation
Owner
|
Just wondering why you added that line to the database, should already be hard coded to use the proper theme anyways. |
Author
|
added it there so a user (who doesn't know any php) will know what the theme is and if they made a theme easily change. it's minor not even needed |
Owner
|
Yeah, the theme already sets properly in the PHP, additional database muddling should be avoided if possible. Thanks for the bitcoin class fix though! |
Author
|
Also got a suggestion for adding additional database handlers when you use php5-mysqlnd it messes with projects that require a php5-mysql strictly. I was working on adding a $config['db']['type'] to config but would need changing ALOT of stuff and a big hassle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Great work on the project here are a few fixes i had to apply to get the project to work correctly