Implemented fluidics interface for syringe pump. #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
These can be merged as long as they don’t break the functionality of the peristaltic pump. I don’t have a peristaltic pump available to test. |
Contributor
Author
|
I'll test this afternoon |
Collaborator
|
Let me also pull this branch and test it on my systems before we merge it. I should be able to run this test tomorrow. |
Contributor
Author
|
This worked fine for my peristaltic pump, there's a minor issue where it wasn't able to parse the default_config.xml file that it attemps loads upon open, I'm trying to trace down why that is and resolve it, but it parsed the protocol/valve config file I use without issue/changes and ran through the protocols properly. |
Member
|
@emanuega @jeffmoffitt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to get back onto master, can these be merged or are additional changes needed?