Skip to content

Steve x nathan sig bug (do not review) #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
n-hutton wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Steve x nathan sig bug (do not review) #17

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8d19e7b
cherrry pick fixed files
n-hutton Jul 7, 2022
455fd72
schnorr fix
n-hutton Jul 13, 2022
8266ea0
add debug string
n-hutton Jul 13, 2022
b125d60
fix...
n-hutton Jul 13, 2022
7bc2dd5
tidy away cout
n-hutton Jul 15, 2022
0e6552f
tidying
n-hutton Jul 15, 2022
8a141e6
style
n-hutton Jul 15, 2022
27b7c8d
fix
n-hutton Jul 15, 2022
66b1ae3
style..
n-hutton Jul 15, 2022
125cd4b
do not include reverted files
Aug 11, 2022
599c0c5
abort when we see a possible failure case
Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/libSchnorr/src/Schnorr_PubKey.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@
#include <openssl/ec.h>
#include <openssl/err.h>

#include <iostream>
#include <csignal>
#include <iostream>
#include <cstdlib>

#include "Schnorr.h"
#include "SchnorrInternal.h"

Expand Down Expand Up @@ -112,8 +117,14 @@ bool PubKey::Serialize(bytes& dst, unsigned int offset) const {
}

bool PubKey::Deserialize(const bytes& src, unsigned int offset) {

if (src.size() != PUB_KEY_SIZE && src.size() != (PUB_KEY_SIZE * 2)) {
std::cout << "Deserialized pubkey size is incorrect with size: " << src.size() << std::endl;
std::abort();
}

shared_ptr<EC_POINT> result =
ECPOINTSerialize::GetNumber(src, offset, PUB_KEY_SIZE);
ECPOINTSerialize::GetNumber(src, offset, src.size());

if (result == nullptr) {
// ECPOINTSerialize::GetNumber failed
Expand Down