Skip to content

Add youtube short parsing #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FoxxMD wants to merge 2 commits into
base: master
Choose a base branch
from
+4,324 −3,075
Open

Add youtube short parsing #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1df4555
Specify node/npm version and update npm lock
FoxxMD Jul 19, 2023
6b68d73
Add youtube short parsing
FoxxMD Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
lts/gallium
10 changes: 9 additions & 1 deletion lib/provider/youtube.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,15 @@ YouTube.prototype.parseVideoUrl = function(url) {
var match = url.match(
/(?:(?:v|vi|be|videos|embed)\/(?!videoseries)|(?:v|ci)=)([\w-]{11})/i
);
return match ? match[1] : undefined;
if (match) {
return match[1];
}
// match youtube shorts
match = url.match(/youtube.com\/shorts\/([\w-]{11})/i);
if (match) {
return match[1];
}
return undefined;
};

YouTube.prototype.parseChannelUrl = function(url) {
Expand Down
2 changes: 2 additions & 0 deletions lib/provider/youtube.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ test('YouTube: regular urls', () => {
'http://www.youtube.com/watch?v=HRb7B9fPhfA',
'http://youtu.be/HRb7B9fPhfA',
'https://m.youtube.com/details?v=HRb7B9fPhfA',
'https://youtube.com/shorts/HRb7B9fPhfA',
],
});
testUrls(newParser(), {
Expand All @@ -69,6 +70,7 @@ test('YouTube: regular urls', () => {
'http://youtu.be/HRb7B9fPhfA?t=30s',
'http://youtu.be/HRb7B9fPhfA#t=30s',
'//youtube.com/embed/HRb7B9fPhfA?start=30',
'https://youtube.com/shorts/HRb7B9fPhfA?t=30s',
],
});
testUrls(newParser(), {
Expand Down
Loading