Added 8-way rolling animations#44
Open
xJusteen47 wants to merge 1 commit intoZsoltMolnarrr:1.20.1from
Open
Conversation
Owner
|
As far as I can tell, this PR adds assets basically replicated from ElenaiDodge. Even if software license allows such content copying, I am not adding anything as such, unless the original author expresses explicit happy support of the idea. |
Author
|
Those are just placeholders, I can ask the dev, but the important thing is
the code for enabling that. You can just scrap those
Il giorno dom 7 apr 2024 alle 12:17 Molnár Zsolt ***@***.***>
ha scritto:
… As far as I can tell, this PR adds assets basically replicated from
ElenaiDodge.
Even if software license allows such content copying, I am not adding
anything as such, unless the original author expresses explicit happy
support of the idea.
—
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BALMB5KWLDOSKLNUJBYE77DY4EMKRAVCNFSM6AAAAABFMKIYYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGQYDMOJXHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’ve added the possibility to have a different animation for each of the main 8 directions.
I’ve added a config setting that allows you to make so the character can face the same direction it was facing before starting the roll, for the whole roll animation, in order to make it more compatible with existing animations.
it can be turned on or off in the client settings.
the 8 animations added are from here:
https://github.com/ElenaiDev/ElenaiDodge2.0