Fixes for loading document from stream#10
Open
avonwyss wants to merge 3 commits intoZubastic:masterfrom
Open
Conversation
|
This is how I do it in my fork of this project. (I have not submitted a pull request.) |
…ing garbage collected
Author
That's indeed a very good point! I have adjusted my PR accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PdfDocument constructor which accepts a stream and the FPDF_LoadDocument methods were confusing, since they did not use their "stream" and "count" parameters, but instead the low-level undocumented "fileRead".
I cleaned this up, and added a small improvement when using MemoryStream streams (direcly copy from buffer instead of reading from stream). Successfully tested the functionality with the Test.Console application: