added dynamic svg placeholder#39
Open
shakee93 wants to merge 1 commit intoa3rev:masterfrom
shakee93:master
Open
added dynamic svg placeholder#39shakee93 wants to merge 1 commit intoa3rev:masterfrom shakee93:master
shakee93 wants to merge 1 commit intoa3rev:masterfrom
shakee93:master
Conversation
|
@shakee93 - Thanks, this is a much needed feature in A3 Lazy load. Note: Base64 encoding is not needed with SVG placeholders. |
|
Amazing idea, just realized that we have a huge CLS issue because of the default placeholder.gif doesn't respect the aspect ratio of the images. Tried it and it worked like a charm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds support to dynamic svg/base64 datauri placeholder instead of the image placeholder. only if there is width and height attribute present in the img tag. this helps eliminate the reflow the jitter we get while lazy loading (cls : https://web.dev/cls/).
this pull doesn't break the default behaviour. it uses the default
_placeholder_urlonly works whenabove filter is set to true.