fixing the 'display' value check on placeHolder to include CSS computed style as well#375
Open
kubaprzetakiewicz wants to merge 1 commit intoa5hik:masterfrom
Open
fixing the 'display' value check on placeHolder to include CSS computed style as well#375kubaprzetakiewicz wants to merge 1 commit intoa5hik:masterfrom
kubaprzetakiewicz wants to merge 1 commit intoa5hik:masterfrom
Conversation
kubaprzetakiewicz
changed the title
display value check to include CSS computed style as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now
insertBeforeandinsertAfterlook only afterelement.styleinline CSS, which in case of unaltered by JS, normal table would be empty.User Agent Stylesheet default styles and user styles have to be checked via either
Element.currentStyle(IE6) or standardizedwindow.getComputedStyle.This way it will detect default
table-rowvalue fordisplayproperty and properly ignore it.