Skip to content

Unify test case handling to fix missing isSkipped check #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
a7ex merged 1 commit into from
Oct 24, 2025
Merged

Unify test case handling to fix missing isSkipped check #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 27 additions & 24 deletions Sources/xcresultparser/JunitXML.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,19 +258,11 @@ public struct JunitXML: XmlSerializable {
) : group.testSuiteXML(numFormatter: numFormatter)

for thisTest in tests {
let testcase = thisTest.xmlNode(
let testcase = createTestCase(
test: thisTest,
classname: group.nameString,
numFormatter: numFormatter,
format: testReportFormat,
nodeNames: nodeNames
failureSummaries: failureSummaries
)
if thisTest.isFailed {
if let summary = thisTest.failureSummary(in: failureSummaries) {
testcase.addChild(summary.failureXML(projectRoot: projectRoot))
} else {
testcase.addChild(failureWithoutSummary)
}
}
node.addChild(testcase)
}
return node
Expand All @@ -281,26 +273,37 @@ public struct JunitXML: XmlSerializable {
) -> [XMLElement] {
var combined = [XMLElement]()
for thisTest in tests {
let testcase = thisTest.xmlNode(
let testcase = createTestCase(
test: thisTest,
classname: name,
numFormatter: numFormatter,
format: testReportFormat,
nodeNames: nodeNames
failureSummaries: failureSummaries
)
if thisTest.isFailed {
if let summary = thisTest.failureSummary(in: failureSummaries) {
testcase.addChild(summary.failureXML(projectRoot: projectRoot))
} else {
testcase.addChild(failureWithoutSummary)
}
} else if thisTest.isSkipped {
testcase.addChild(skippedWithoutSummary)
}
combined.append(testcase)
}
return combined
}

private func createTestCase(
test: ActionTestMetadata, classname: String, failureSummaries: [TestFailureIssueSummary]
) -> XMLElement {
let testcase = test.xmlNode(
classname: classname,
numFormatter: numFormatter,
format: testReportFormat,
nodeNames: nodeNames
)
if test.isFailed {
if let summary = test.failureSummary(in: failureSummaries) {
testcase.addChild(summary.failureXML(projectRoot: projectRoot))
} else {
testcase.addChild(failureWithoutSummary)
}
} else if test.isSkipped {
testcase.addChild(skippedWithoutSummary)
}
return testcase
}

private var failureWithoutSummary: XMLElement {
return XMLElement(name: "failure")
}
Expand Down