Improve eslint

[atrovato]

Based on #155 comment: split PR eslint first :)

[atrovato]

@rzr you commented:

please explain why this was changed ?

As file content is json, quotes are not required here.

[atrovato]

I use \" to be able to run on windows env.

[rzr]

Please add a change to ignore modules too ie :

https://github.com/abandonware/noble/pull/171/checks?check_run_id=1844386700#

s/home/runner/work/noble/noble/node_modules/mocha/lib/mocha.js:1215for await (const fixtureFn of fixtureFns) {^^^^^

[atrovato]

This error is not linked to eslint but to node 8 build. Should I do in this PR or in a separate one?

[atrovato]

With eslint 7, node 8 is no longer supported

https://eslint.org/docs/user-guide/migrating-to-7.0.0#nodejs-8-is-no-longer-supported

[atrovato]

And As of v8.0.0, Mocha requires Node.js v10.12.0 or newer.

https://mochajs.org/#installation

[atrovato]

Ok I changed nodepackage.yml to ignore lin on node 8, and to use mocha 7.2.0 on node 8.

[rzr]

sounds good to me

[rzr]

please open new pr with this change : b76fa34#diff-b29da93bc686f97c01ba07c233850a8c2a21d53cbe9bfc153f905640106da66b and then your eslint fixes then you can rebase everything to make sure nothing break

[rzr]

please rebase with only eslint changes

[atrovato]

Done :)