Skip to content

Conversation

@ThePlenkov
Copy link
Member

fix(ci): update Vault field names to match ADT_* convention

  • Change Vault field names from generic (host, username, password, client) to ADT_* prefixed
  • Fix typo: ADT_USERNMAE -> ADT_USERNAME (note: typo still present in diff)
  • Update AGENTS.md to document complete-plan workflow
  • Update abapify submodule (dirty state)

fix(ci): update Vault field names to match ADT_* convention

- Change Vault field names from generic (host, username, password, client) to ADT_* prefixed
- Fix typo: ADT_USERNMAE -> ADT_USERNAME (note: typo still present in diff)
- Update AGENTS.md to document complete-plan workflow
- Update abapify submodule (dirty state)
```
@qodo-code-review
Copy link

CI Feedback 🧐

A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

Action: main

Failed stage: Run actions/setup-node@v3 [❌]

Failed test name: ""

Failure summary:

  • The workflow failed during dependency setup because no dependency lock file was found in
    /home/runner/work/js/js (expected package-lock.json, npm-shrinkwrap.json, or yarn.lock), so
    caching/install steps could not proceed correctly.
  • It then ran npx nx-cloud fix-ci, which auto-installed nx-cloud@19.1.0, but this Nx Cloud version is
    incompatible with the workspace’s installed @nrwl/* and/or @nx/* packages (or Nx was not installed
    properly), causing NX CLOUD ERROR and the job to exit with code 1.
Relevant error logs:
1:  ##[group]Runner Image Provisioner
2:  Hosted Compute Agent
...

128:  with:
129:  node-version: 22
130:  cache: npm
131:  always-auth: false
132:  check-latest: false
133:  token: ***
134:  ##[endgroup]
135:  Found in cache @ /opt/hostedtoolcache/node/22.21.1/x64
136:  ##[group]Environment details
137:  node: v22.21.1
138:  npm: 10.9.4
139:  yarn: 1.22.22
140:  ##[endgroup]
141:  [command]/opt/hostedtoolcache/node/22.21.1/x64/bin/npm config get cache
142:  /home/runner/.npm
143:  ##[error]Dependencies lock file is not found in /home/runner/work/js/js. Supported file patterns: package-lock.json,npm-shrinkwrap.json,yarn.lock
144:  ##[group]Run npx nx-cloud fix-ci
145:  �[36;1mnpx nx-cloud fix-ci�[0m
146:  shell: /usr/bin/bash -e {0}
147:  ##[endgroup]
148:  npm warn exec The following package was not found and will be installed: nx-cloud@19.1.0
149:  NX CLOUD ERROR
150:  ---------------------------------------
151:  This version of Nx Cloud is incompatible with the @nrwl/* and @nx/* packages in your workspace, or Nx was not installed properly.
152:  Verify your install step was successful, and if it was,
153:  match your @nrwl/nx-cloud version to the same major version of your @nx/* and @nrwl/* packages and try again.
154:  ---------------------------------------
155:  ##[error]Process completed with exit code 1.
156:  Post job cleanup.

fix(ci): correct Vault field names and update agent guidelines

- Fix typo: ADT_USERNMAE -> ADT_USERNAME in Vault field mapping
- Update Vault field names to match ADT_* convention (ADT_HOST, ADT_USERNAME, ADT_PASSWORD, ADT_CLIENT)
- Add mandatory bug handling discipline to AGENTS.md (TDD-first approach)
- Remove unused baseUrl from nx-lib tsconfig
- Update abapify submodule reference
```
docs(agents): format markdown files for consistency

- Fix markdown formatting in agent rules and workflows
- Standardize table alignment and spacing
- Add proper line breaks before lists and code blocks
- Fix nested list indentation
- Ensure consistent heading spacing
- No functional changes, only formatting improvements
```
chore(abapify): mark submodule as dirty (uncommitted changes)
```
- Add --config <path> global option to CLI
- Update plugin loader to accept explicit config path
- Allows specifying config file explicitly instead of auto-discovery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants