-
Notifications
You must be signed in to change notification settings - Fork 1
``` #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ThePlenkov
wants to merge
19
commits into
main
Choose a base branch
from
feature/atc-checks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
``` #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(ci): update Vault field names to match ADT_* convention - Change Vault field names from generic (host, username, password, client) to ADT_* prefixed - Fix typo: ADT_USERNMAE -> ADT_USERNAME (note: typo still present in diff) - Update AGENTS.md to document complete-plan workflow - Update abapify submodule (dirty state) ```
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
fix(ci): correct Vault field names and update agent guidelines - Fix typo: ADT_USERNMAE -> ADT_USERNAME in Vault field mapping - Update Vault field names to match ADT_* convention (ADT_HOST, ADT_USERNAME, ADT_PASSWORD, ADT_CLIENT) - Add mandatory bug handling discipline to AGENTS.md (TDD-first approach) - Remove unused baseUrl from nx-lib tsconfig - Update abapify submodule reference ```
docs(agents): format markdown files for consistency - Fix markdown formatting in agent rules and workflows - Standardize table alignment and spacing - Add proper line breaks before lists and code blocks - Fix nested list indentation - Ensure consistent heading spacing - No functional changes, only formatting improvements ```
- Add --config <path> global option to CLI - Update plugin loader to accept explicit config path - Allows specifying config file explicitly instead of auto-discovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(ci): update Vault field names to match ADT_* convention