Add logging to TenantResolver for tenant resolution #24376
Merged
+22
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds debug-level logging to the TenantResolver class to improve observability during tenant resolution operations. The changes include adding a logger property, refactoring private fields to protected properties for better extensibility, and inserting logging statements at key points in the tenant resolution flow.
Key changes:
- Added
ILogger<TenantResolver>property withNullLoggerinitialization following the codebase's standard pattern - Converted private fields to protected properties (
ServiceProviderandOptions) to support potential inheritance scenarios - Added debug logging at tenant resolution start, during each resolver attempt, upon successful resolution, and for fallback scenarios
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
framework/src/Volo.Abp.MultiTenancy/Volo/Abp/MultiTenancy/TenantResolver.cs
Outdated
Show resolved
Hide resolved
framework/src/Volo.Abp.MultiTenancy/Volo/Abp/MultiTenancy/TenantResolver.cs
Outdated
Show resolved
Hide resolved
framework/src/Volo.Abp.MultiTenancy/Volo/Abp/MultiTenancy/TenantResolver.cs
Outdated
Show resolved
Hide resolved
…ntResolver.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ntResolver.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ntResolver.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
EngincanV
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://abp.io/support/questions/10139