Skip to content

Fix: If ticket/1 is inaccessible, roust would throw in authenticated #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erdgeist wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix: If ticket/1 is inaccessible, roust would throw in authenticated #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f31b4e
Fix: If ticket/1 is inaccessible, roust would throw in authenticaed
erdgeist Oct 20, 2016
c96ea1d
Cookies are now set differently in HTTParty, RT4.4+ requires referer
erdgeist Nov 7, 2017
3cf3c48
Make referer symbol a string
erdgeist Nov 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/roust.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ def authenticate!
)

cookie = response.headers['set-cookie']
self.class.headers['Cookie'] = cookie if cookie
self.class.default_cookies.add_cookies(cookie) if cookie
self.class.headers('Referer' => "#{@server}/REST/1.0")

# Switch the base uri over to the actual REST API base uri.
self.class.base_uri "#{@server}/REST/1.0"
Expand All @@ -60,7 +61,8 @@ def authenticate!
end

def authenticated?
return true if show('1')
show('1')
return true
rescue Unauthenticated
return false
end
Expand Down
1 change: 1 addition & 0 deletions lib/roust/ticket.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ def ticket_show(id)
body, _ = explode_response(response)

return nil if body =~ /^# (Ticket (\d+) does not exist\.)/
return nil if body =~ /^# You are not allowed to display ticket (\d+)./

parse_ticket_attributes(body)
end
Expand Down