Skip to content

bugfix: remove infinite increasing ignore set #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brian316 merged 1 commit into from
May 27, 2025
Merged

bugfix: remove infinite increasing ignore set #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions app/core/monitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ class JobMonitor:
def __init__(self):
self.stop_monitoring = False
self.monitoring_task = None
self._ignore_jobs = (
set()
) # Keep ignore list to avoid reprocessing completed jobs

async def _get_queue_info(self) -> dict[str, int]:
"""Get queue information with fallback"""
Expand Down Expand Up @@ -137,13 +134,9 @@ async def monitor_jobs(self):
for job in jobs:
job_id = job.metadata.name

# Skip previously completed jobs
if job_id in self._ignore_jobs:
logger.debug(f"ignoring job: {job_id}")
continue

if not job.status.conditions:
logger.warning(f"Job conditions not ready for {job_id}")
await asyncio.sleep(0.1)
continue

conditions = job.status.conditions[-1]
Expand All @@ -157,7 +150,8 @@ async def monitor_jobs(self):
if status in TrainingJobStatus.stopped_states:
job_info = await db_manager.get_job(job_id)
if job_info and job_info.status == status:
self._ignore_jobs.add(job_id)
# ignore jobs that are already in stopped states
await asyncio.sleep(0.1)
continue

# check if state changed
Expand Down Expand Up @@ -185,8 +179,6 @@ async def monitor_jobs(self):

# Additional handling for completed jobs
if is_completed:
self._ignore_jobs.add(job_id)

if status == KubeflowStatusEnum.succeeded:
logger.info(
f"Job {job_id} completed successfully, cleaning up"
Expand Down Expand Up @@ -229,7 +221,6 @@ async def stop(self):
except asyncio.CancelledError:
pass
finally:
self._ignore_jobs.clear()
self.monitoring_task = None


Expand Down