Skip to content

Conversation

@themoenen
Copy link
Collaborator

@themoenen themoenen commented May 23, 2025

Two issues have been addressed:

  1. Prevent os.remove(training_file) error from interrupting process when running in concurrent threads
  2. Fixed the spinner implementation so it's properly disabled in API mode, regardles of where it's being called
    --> Simplified redundent GLOBAL_SETTINGS["VERBOSE"] with GLOBAL_SETTINGS["display"] != "api"

Note: Toolkit files have been updated to avoid inconsistency but this is all dead code and will be removed

Copy link
Contributor

@PhillipDowney PhillipDowney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note they changed legacy RXN toolkit, try and avoid find replace on naming.

@PhillipDowney PhillipDowney merged commit 0357637 into main May 26, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants