History memory leak fix #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian316
reviewed
May 29, 2025
| "", | ||
| return_val=False, | ||
| ) | ||
| if num_results < 4 or GLOBAL_SETTINGS["display"] == "api":: |
Collaborator
There was a problem hiding this comment.
@themoenen added this fix. not sure how this got passed by. can you test?
Signed-off-by: Brian Duenas <brian.duenas@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked readline history to fix a memory leak. This was due to
readline.read_history_file()causing the entire history to be appended instead of overwriting the in-memoru history. Then, certain conditions would cause the history to be doubled with every command, leading to memory overload.