clone relations to avoid InmmutableRelation #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n newer versions Error
Author
|
This mitigates these issues inossidabile#73, inossidabile#74 but I need to add some tests and validate other scenarios. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what?
clone relations to avoid InmmutableRelation deprecation warning and in newer versions Error
why?
Rails and ActiveRecord trigger a deprecation warning when reloads a relation already cached by Arel
rails/rails#14848
rails/rails@1b7aa62
rails/rails@3ae9818
Is this a patch or stable version?
At this point this is a patch, I'll take a look into the official repo. I'll prefer to use the core solution.