This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Fixed: children windows become orphans when main evolution window gets closed first#2
Open
pavelgood wants to merge 1 commit intoacidrain42:masterfrom
Open
Conversation
…ted and main evolution window gets closed before them. Solution: using "delete-event" instead of "quit-requested" event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this commit (PR) is to fix one small but quite annoying BUG, that
apears when "hide on close" feature is enabled. Steps to reproduce:
* enable "hide on close" feature
* open the main evolution window
* open at least one email message (should appear in a separate window)
* close the main window (should disappear and probably be closed/destroyed but not hidden)
* close the child window (BUG: child is orphan now and can't be closed, tray icon doesn't toggle main window anymore)
Issue: current implementation is based on "quit-requested" event interception, which is sent only when last window (main or child) is about to be closed as it means to quit the application. It works fine when all children windows get closed first but causes a problem othewise.
Proposal: using "delete-event" instead of "quit-requested".