Open
Conversation
G-Rath
requested review from
JacobBriggsAckama,
eoinkelly,
halles,
hmaddocks,
hopkincame,
joshmcarthur,
lukeify and
robotdana
JacobBriggsAckama
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running our "checks" generally takes less than a minute which is quite affordable, and this way you can know if your tests are failing in parallel to linting. I've also found it useful in codebases where we've ended up splitting the test suite up in some way due to performance and flakiness, since the "checks" job can just left as-is.
The only annoying thing is that
annotaterbuses the database which is now only being set up in the tests job since it adds an extra ~20 seconds just having the service, so I've cheekily put that in the tests job even though it's actually a check.Also note that currently
annotaterbwill not error if it cannot connect to the database, making it easy to assume it does not need that 😕