Danger #155
Draft
Danger #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acm19
force-pushed
the
danger
branch
2 times, most recently
from
df02513 to
c3bef33
Compare
Collaborator
|
The token thing means that the token will get revoked quickly. The "right" approach is to use dblock/danger-changelog#65, then you don't need the token as the CI runs on PR, but the comment gets appended on pull request target. |
acm19
force-pushed
the
danger
branch
2 times, most recently
from
46899bd to
c03a0a4
Compare
Generated by 🚫 Danger |
Owner
Author
|
@dblock I made it work here, but the error is quite cryptic. It doesn't really explain why it's not happy with the changelog. Maybe some config I'm missing. |
Collaborator
It adds a comment to PRs, #155 (comment), and yes it should log it in the logs but I think it doesn't. This works here because you're not working off a fork, don't merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.