Adding (initial) luajit support to vert #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcr--
commented
Feb 8, 2021
| LUA_VERSION="%s" | ||
| VERT="%s" | ||
| LUA_VERSION="%{lua_version}" | ||
| VERT="%{prefix}" |
Author
There was a problem hiding this comment.
I think a syntax like this for the templates is nicer than using the %s we had before.
fcr--
commented
Feb 8, 2021
| end | ||
|
|
||
| activate_file:write(string.format(template, lua_version, prefix)) | ||
| activate_file:write((template:gsub("%%{([%w_]+)}", function(var) |
Author
There was a problem hiding this comment.
instead of %s, this replaces %{var_name} with the content of params.var_name (or an empty string if not defined)
Now we have to grab the .tar.gz files from the repository, and guess the commit version that is reflected in the extracted directory path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
luajitonvert, or at least it tries to.Since I only tested it on my computer (ubuntu 20.04 LTS on amd64), I did not yet add it to the documentation, specially since I feel the chances of this working on windows may be rather slim. That said I think all in all this is worthwhile.