Skip to content

feat(layout): improve responsive chart layout #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acooks merged 1 commit into from
Aug 3, 2025
Merged

feat(layout): improve responsive chart layout #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions html5-client/src/css/jittertrap.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,3 +120,21 @@
footer a {
color: #4682B4;
}

@media (min-width: 1920px) {
#chartsPanel .tab-content {
display: flex;
flex-direction: row;
}

#tputPanel, #toptalkPanel {
display: block !important;
opacity: 1 !important;
flex: 0 0 50%;
max-width: 50%;
}

#showTputPanel, #showTopTalkPanel {
display: none;
}
}
4 changes: 2 additions & 2 deletions html5-client/src/html/index.tpl.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

</head>
<body>
<div class="container pt-3">
<div class="container-fluid pt-3">
<div class="card">
<div class="card-body">
<div class="row align-items-center">
Expand Down Expand Up @@ -69,7 +69,7 @@
<!-- end modals -->
</div>

<footer class="container pt-3 text-center">
<footer class="container-fluid pt-3 text-center">
<p>
<a href="#" data-toggle="modal" data-target="#about">About</a>
&middot;
Expand Down
9 changes: 7 additions & 2 deletions html5-client/src/js/jittertrap-chart-toptalk.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,11 @@
const width = size.width - margin.left - margin.right;
const height = 300; // Use a fixed height for the chart drawing area

// Update canvas and SVG dimensions
canvas.attr("width", width)
.attr("height", height);
svg.attr("width", width + margin.left + margin.right);

xScale = d3.scaleLinear().range([0, width]);
/* compute the domain of x as the [min,max] extent of timestamps
* of the first (largest) flow */
Expand All @@ -314,8 +319,8 @@
xAxis.scale(xScale);
yAxis.scale(yScale);

xGrid.scale(xScale);
yGrid.scale(yScale);
xGrid.scale(xScale).tickSize(-height);
yGrid.scale(yScale).tickSize(-width);

svg = d3.select("#chartToptalk");

Expand Down