This repository was archived by the owner on Nov 16, 2021. It is now read-only.
Media Library plugin for CKEditor#47
Merged
balsama merged 4 commits intoacquia:8.x-1.xfrom Nov 12, 2015
phenaproxima:media_embed
Merged
Media Library plugin for CKEditor#47balsama merged 4 commits intoacquia:8.x-1.xfrom phenaproxima:media_embed
balsama merged 4 commits intoacquia:8.x-1.xfrom
phenaproxima:media_embed
Conversation
Contributor
There was a problem hiding this comment.
As discussed, I think all of the media entity plugins need to be requirements here. Please add:
- media_pinkeye
- media_entity_slideshow
- media_entity_instagram
- media_entity_twitter
- media_entity_image
balsama
added a commit
that referenced
this pull request
Nov 12, 2015
Media Library plugin for CKEditor
There was a problem hiding this comment.
I'm curious why this need to define a new embed type when you're basically embedding entities (which should be supported by Entity Embed, and adding a button to embed media_entity entities)?
Collaborator
Author
There was a problem hiding this comment.
I think this is just future-proofing on my part so that we have extra flexibility if we need it. But yes, at the moment we're not doing anything dramatically different from what Entity Embed already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides the very early alpha of a simple Media Library plugin for CKEditor.
The media library is opened in a modal dialog box by a button in the CKE toolbar, and rendered client-side using Backbone. The items in the media library are fetched over AJAX using a view (which in turn causes the lightning_media module to rely on the core REST and Serialization modules), and when clicked they are directly embedded into the CKEditor document using Entity Embed. It just works.
drupal-media/entity_embed#189 is related to this here PR. I don't think it's an outright dependency, but this work resulted in that patch.
Right now, the media library button will need to be added manually to a CKEditor configuration (and entity embedding will need to be enabled for the text format). Later we can maybe add that as a default to (certain? all?) text formats included with Lightning.