Delete versions for multiple packages #96
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there is no need to get totalCount if it is not going to be used - remove faulty tap call on getPackageNames method - remove totalCount on query, as pageInfo.hasNextPage is enough for pagination - remove totalCount on graphql.mock.ts
- move graphql.ts to a common folder - update imports - remove duplicate graphql.ts
This reverts commit 968ce24.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR exists because #72 hasn't been update in a while and was not working At all.
the functionality for this PR can be tested using
and we have used it internally to delete versions for 47 packages at the same time. of course we are limited by the 100 rate limit but ours is an extreme case.
I don't know how much maintenance I can do on this PR so someone else might want to take over if more changes are needed.