refactor: simplify zod-adapter to use Zod 4's built-in toJSONSchema #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leverage Zod 4's native toJSONSchema() method instead of manually parsing internal _def structure. This reduces adapter complexity from ~250 lines to ~85 lines and improves maintainability. - Update peer dependency from zod ^3.0.0 to ^4.0.0 - Replace manual type inspection with schema.toJSONSchema() call - Update isZodSchema to detect toJSONSchema method presence - Simplify tests to use actual Zod schemas instead of mocks
Update installation docs to specify Zod 4 or later is required for structured output validation with the SDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverage Zod 4's native toJSONSchema() method instead of manually
parsing internal _def structure. This reduces adapter complexity
from ~250 lines to ~85 lines and improves maintainability.