feat(config): implement hash-based auth.json change detection #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Files Modified ### lib/types.ts - Added authFileHash?: string field to AuthSyncConfig interface ### lib/config.ts - Added writeFile import - Added getConfigPath() function to find existing config file path - Added saveConfig() function to persist config with hash ### lib/watcher.ts - Added crypto.createHash import for SHA-256 hashing - Added computeHash() function to compute SHA-256 hash of content - Added WatcherOptions interface with debounceMs and storedHash - Updated WatcherCallbacks.onCredentialsChange signature to include hash parameter - Changed hash comparison logic: compares current hash against stored hash instead of string comparison ### index.ts - Updated imports to include getConfigPath, saveConfig, AuthSyncConfig - Added persistHash() function to save hash to config after successful sync - Updated handleCredentialsChange callback to handle hash parameter and persist on success - Updated watcher call to pass storedHash from config ### lib/watcher.test.ts (new file) - Unit tests for computeHash() function (6 tests) - Unit tests for hash comparison in watcher (9 tests) ### lib/config.test.ts - Added tests for saveConfig() function (3 tests) - Added tests for get Attempt: att-49ee1ad5-3e93-4979-a4d4-53c3e4732eae Profile: apg-70541e2b-d01c-4d50-a814-7025ac222ebe
Contributor
AI Review SummaryVerdict: APPROVE Findings
Overall AssessmentExcellent implementation of hash-based change detection with comprehensive test coverage and proper per-repository tracking. Previously flagged issue regarding hash persistence after partial failures has been resolved. One minor documentation inconsistency noted (low severity). |
Attempt: att-49ee1ad5-3e93-4979-a4d4-53c3e4732eae Profile: apg-70541e2b-d01c-4d50-a814-7025ac222ebe
**Changes:** | File | Change | |------|--------| | lib/types.ts | authFileHash?: string → authFileHashes?: Record<string, string> | | schema.json | Updated to object type with string values | | index.ts | Per-repo filtering, individual hash updates, toast per failed repo | | lib/config.test.ts | Updated all tests for new structure | **Behavior:** On restart, only repos with stale/missing hashes sync. Failed repos retry automatically. Attempt: att-49ee1ad5-3e93-4979-a4d4-53c3e4732eae Profile: apg-70541e2b-d01c-4d50-a814-7025ac222ebe
activadee
deleted the
OAS/OAS-2-oas-2-implement-hash-based-auth.json-change-detection-to-optimiz
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #1