Skip to content

Conversation

@alexkwolfe
Copy link
Contributor

@alexkwolfe alexkwolfe commented Oct 28, 2021

Description of the change

On a call with a LeadConduit prospect, they identified that they allocate leads based on the SCF code. This PR adds a little extra parsing to make it easy to build rules on the SCF.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change
  • Technical Debt
  • Documentation

Related tickets

No related ticket.

Checklists

Development and Testing

  • Lint rules pass locally.
  • The code changed/added as part of this pull request has been covered with tests, or this PR does not alter production code.
  • All tests related to the changed code pass in development, or tests are not applicable.

Code Review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • At least two engineers have been added as "Reviewers" on the pull request.
  • Changes have been reviewed by at least two other engineers who did not write the code.
  • This branch has been rebased off master to be current.

Tracking

  • Issue from Clubhouse has a link to this pull request.
  • This PR has a link to the issue in Clubhouse.

QA

  • This branch has been deployed to staging and tested.

@alexkwolfe alexkwolfe requested a review from mikebetts October 28, 2021 20:19
Copy link

@NathanielInman NathanielInman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, awaiting testing success. Something is up with npm i

Copy link
Contributor

@asedarski asedarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR needs to be updated and tests fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants