-
Notifications
You must be signed in to change notification settings - Fork 111
Otters - Jodi Denney #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,36 @@ | ||
| import React from 'react'; | ||
| import './App.css'; | ||
| import chatMessages from './data/messages.json'; | ||
| import ChatLog from './components/ChatLog'; | ||
| import { useState } from 'react'; | ||
|
|
||
| const App = () => { | ||
| const [entries, setEntries] = useState(chatMessages); | ||
| const [likes, setLikes] = useState(0); | ||
|
Comment on lines
+7
to
+8
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So organized, setting all the state variables at the top of the component! Love to see it 💖 |
||
|
|
||
| const toggleHeart = (id) => { | ||
| let currentLikes = 0; | ||
| const newEntries = entries.map((entry) => { | ||
| const newEntry = { ...entry }; | ||
| if (newEntry.id === id) { | ||
| newEntry.liked = !newEntry.liked; | ||
| } | ||
| if (newEntry.liked === true) { | ||
| currentLikes += 1; | ||
| } | ||
| return newEntry; | ||
| }); | ||
| setEntries(newEntries); | ||
| setLikes(currentLikes); | ||
|
Comment on lines
+22
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oooo, so efficient. ✨ |
||
| }; | ||
|
|
||
| return ( | ||
| <div id="App"> | ||
| <header> | ||
| <h1>Application title</h1> | ||
| <h1>Chat between Vladimir and Estragon</h1> | ||
| <h2>{likes} ❤️s</h2> | ||
| </header> | ||
| <main> | ||
| {/* Wave 01: Render one ChatEntry component | ||
| Wave 02: Render ChatLog component */} | ||
| <ChatLog entries={entries} toggleHeartCallback={toggleHeart} /> | ||
| </main> | ||
| </div> | ||
| ); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,53 +1,53 @@ | ||
| import React from 'react' | ||
| import App from './App' | ||
| import { render, screen, fireEvent } from '@testing-library/react' | ||
| import React from 'react'; | ||
| import App from './App'; | ||
| import { render, screen, fireEvent } from '@testing-library/react'; | ||
|
|
||
| describe('Wave 03: clicking like button and rendering App', () => { | ||
| test('that the correct number of likes is printed at the top', () => { | ||
| // Arrange | ||
| const { container } = render(<App />) | ||
| let buttons = container.querySelectorAll('button.like') | ||
| const { container } = render(<App />); | ||
| let buttons = container.querySelectorAll('button.like'); | ||
|
|
||
| // Act | ||
| fireEvent.click(buttons[0]) | ||
| fireEvent.click(buttons[1]) | ||
| fireEvent.click(buttons[10]) | ||
| fireEvent.click(buttons[0]); | ||
| fireEvent.click(buttons[1]); | ||
| fireEvent.click(buttons[10]); | ||
|
|
||
| // Assert | ||
| const countScreen = screen.getByText(/3 ❤️s/) | ||
| expect(countScreen).not.toBeNull() | ||
| }) | ||
| const countScreen = screen.getByText(/3 ❤️s/); | ||
| expect(countScreen).not.toBeNull(); | ||
| }); | ||
|
|
||
| test('clicking button toggles heart and does not affect other buttons', () => { | ||
| // Arrange | ||
| const { container } = render(<App />) | ||
| const buttons = container.querySelectorAll('button.like') | ||
| const firstButton = buttons[0] | ||
| const lastButton = buttons[buttons.length - 1] | ||
| const { container } = render(<App />); | ||
| const buttons = container.querySelectorAll('button.like'); | ||
| const firstButton = buttons[0]; | ||
| const lastButton = buttons[buttons.length - 1]; | ||
|
|
||
| // Act-Assert | ||
|
|
||
| // click the first button | ||
| fireEvent.click(firstButton) | ||
| expect(firstButton.innerHTML).toEqual('❤️') | ||
| fireEvent.click(firstButton); | ||
| expect(firstButton.innerHTML).toEqual('❤️'); | ||
|
|
||
| // check that all other buttons haven't changed | ||
| for (let i = 1; i < buttons.length; i++) { | ||
| expect(buttons[i].innerHTML).toEqual('🤍') | ||
| expect(buttons[i].innerHTML).toEqual('🤍'); | ||
| } | ||
|
|
||
| // click the first button a few more times | ||
| fireEvent.click(firstButton) | ||
| expect(firstButton.innerHTML).toEqual('🤍') | ||
| fireEvent.click(firstButton) | ||
| expect(firstButton.innerHTML).toEqual('❤️') | ||
| fireEvent.click(firstButton) | ||
| expect(firstButton.innerHTML).toEqual('🤍') | ||
| fireEvent.click(firstButton); | ||
| expect(firstButton.innerHTML).toEqual('🤍'); | ||
| fireEvent.click(firstButton); | ||
| expect(firstButton.innerHTML).toEqual('❤️'); | ||
| fireEvent.click(firstButton); | ||
| expect(firstButton.innerHTML).toEqual('🤍'); | ||
|
|
||
| // click the last button a couple times | ||
| fireEvent.click(lastButton) | ||
| expect(lastButton.innerHTML).toEqual('❤️') | ||
| fireEvent.click(lastButton) | ||
| expect(lastButton.innerHTML).toEqual('🤍') | ||
| }) | ||
| }) | ||
| fireEvent.click(lastButton); | ||
| expect(lastButton.innerHTML).toEqual('❤️'); | ||
| fireEvent.click(lastButton); | ||
| expect(lastButton.innerHTML).toEqual('🤍'); | ||
| }); | ||
| }); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,33 @@ | ||
| import React from 'react'; | ||
| import './ChatEntry.css'; | ||
| import PropTypes from 'prop-types'; | ||
| import TimeStamp from './TimeStamp'; | ||
|
|
||
| const ChatEntry = (props) => { | ||
| const toggleHeart = () => { | ||
| props.toggleHeartCallback(props.id); | ||
| }; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Small nit, a space after this life would help with readability! |
||
| return ( | ||
| <div className="chat-entry local"> | ||
| <h2 className="entry-name">Replace with name of sender</h2> | ||
| <h2 className="entry-name">{props.sender} </h2> | ||
| <section className="entry-bubble"> | ||
| <p>Replace with body of ChatEntry</p> | ||
| <p className="entry-time">Replace with TimeStamp component</p> | ||
| <button className="like">🤍</button> | ||
| <p>{props.body}</p> | ||
| <p className="entry-time"> | ||
| <TimeStamp time={props.timeStamp} /> | ||
| </p> | ||
| <button className="like" onClick={toggleHeart}> | ||
| {props.liked ? '❤️' : '🤍'} | ||
| </button> | ||
| </section> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| ChatEntry.propTypes = { | ||
| //Fill with correct proptypes | ||
| id: PropTypes.number.isRequired, | ||
| sender: PropTypes.string.isRequired, | ||
| body: PropTypes.string.isRequired, | ||
| timeStamp: PropTypes.string.isRequired, | ||
| liked: PropTypes.bool, | ||
| }; | ||
|
|
||
| export default ChatEntry; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1,28 @@ | ||
| import React from "react"; | ||
| import "@testing-library/jest-dom/extend-expect"; | ||
| import ChatEntry from "./ChatEntry"; | ||
| import { render, screen, fireEvent, waitFor } from "@testing-library/react"; | ||
| import React from 'react'; | ||
| import '@testing-library/jest-dom/extend-expect'; | ||
| import ChatEntry from './ChatEntry'; | ||
| import { render, screen, fireEvent, waitFor } from '@testing-library/react'; | ||
|
|
||
| describe("Wave 01: ChatEntry", () => { | ||
| describe('Wave 01: ChatEntry', () => { | ||
| beforeEach(() => { | ||
| render( | ||
| <ChatEntry | ||
| sender="Joe Biden" | ||
| body="Get out by 8am. I'll count the silverware" | ||
| body="Get out by 8am. I will count the silverware" | ||
| timeStamp="2018-05-18T22:12:03Z" | ||
| /> | ||
| ); | ||
| }); | ||
|
|
||
| test("renders without crashing and shows the sender", () => { | ||
| test('renders without crashing and shows the sender', () => { | ||
| expect(screen.getByText(/Joe Biden/)).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| test("that it will display the body", () => { | ||
| test('that it will display the body', () => { | ||
| expect(screen.getByText(/Get out by 8am/)).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| test("that it will display the time", () => { | ||
| test('that it will display the time', () => { | ||
| expect(screen.getByText(/\d+ years ago/)).toBeInTheDocument(); | ||
| }); | ||
| }); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import './ChatLog.css'; | ||
| import ChatEntry from './ChatEntry'; | ||
| import PropTypes from 'prop-types'; | ||
|
|
||
| const ChatLog = (props) => { | ||
| const chatComponents = props.entries.map((message) => { | ||
| return ( | ||
| <li key={message.id}> | ||
| <ChatEntry | ||
| id={message.id} | ||
| sender={message.sender} | ||
| body={message.body} | ||
| timeStamp={message.timeStamp} | ||
| liked={message.liked} | ||
| toggleHeartCallback={props.toggleHeartCallback} | ||
| /> | ||
| </li> | ||
| ); | ||
| }); | ||
|
|
||
| return <ul>{chatComponents}</ul>; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Love that you used semantic HTML with |
||
| }; | ||
|
|
||
| ChatLog.propTypes = { | ||
| entries: PropTypes.array.isRequired, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should also add |
||
| }; | ||
|
|
||
| export default ChatLog; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| import React from 'react'; | ||
| import ReactDOM from 'react-dom'; | ||
| import './index.css'; | ||
| import App from './App'; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can combine L1 and L4 into one line because they're both imported from the react library: