Open
Conversation
…to wave 01 and 03 to account for new goal_id attribute
kaidamasaki
reviewed
Jun 1, 2022
kaidamasaki
left a comment
kaidamasaki
left a comment
There was a problem hiding this comment.
Well done!
Your code is clear, clean and easy to read.
Great job!
| "channel" : "task-notifications", | ||
| "text" : f"Someone just completed the task {task.title}" | ||
| } | ||
| headers = {"authorization" : "Bearer " + bot_token} |
There was a problem hiding this comment.
The reason your tests fail on Learn is because you try to use the token without first verifying that it is not None.
A check at the beginning of this that does an early return if there's no token is probably the correct way to solve this (since if Slack/not configured is down you'd like your API to still work).
| try: | ||
| goal_id = int(goal_id) | ||
| except ValueError: | ||
| return jsonify({"msg" : f"'{goal_id}' is invalid"}), 400 |
There was a problem hiding this comment.
Nice job including the invalid goal_id! 😃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.