Sea Turtles - Tiffini H. by tiffinihyatt · Pull Request #99 · ada-c17/task-list-api

tiffinihyatt · 2022-05-13T16:30:40Z

No description provided.

…s wave 02

…tionality, passes wave 03

…s waves 1-3

…ve 05

kelsey-steven-ada

Great work pulling together many concepts in this project Tiffini! Please take a look at the feedback when you have time, and reach out if you have questions or could use clarifications on anything 😊

kelsey-steven-ada · 2022-05-18T03:47:33Z

app/__init__.py

+    from .task_routes import tasks_bp
+    app.register_blueprint(tasks_bp)
+
+    from .goal_routes import goals_bp
+    app.register_blueprint(goals_bp)


Nice, I like the choice to divide the routes into their own files!

kelsey-steven-ada · 2022-05-18T03:49:03Z

app/goal_routes.py

@@ -0,0 +1,90 @@
+from flask import Blueprint, request, jsonify, make_response, abort


It looks like the abort function isn't directly used in this file anymore, so we should remove the import as part of our clean up & refactor steps.

Oh man, I thought I caught all of those! Thanks, Kelsey!

kelsey-steven-ada · 2022-05-18T03:50:09Z

app/models/goal.py

+        if self.tasks:
+            goal_dict["tasks"] = [task.task_id for task in self.tasks]


Nice way to add the attribute that won't always exist!

kelsey-steven-ada · 2022-05-18T03:50:53Z

app/models/goal.py

+
+        if self.tasks:
+            goal_dict["tasks"] = [task.task_id for task in self.tasks]
+            # goal_dict["tasks"] = []


We want to make sure to delete commented out code as part of clean up. When we are sharing a codebase with other folks, it's unclear what the intention of commented out code is, especially without extra comments explaining why it's there. We use versioning tools like git so we can confidently delete code and view our commit history if we need to recover something we wrote prior.

Noted--thank you for catching this!

kelsey-steven-ada · 2022-05-18T03:52:40Z

app/models/task.py

+        if not self.completed_at:
+            task_dict["is_complete"] = False
+        else:
+            task_dict["is_complete"] = True


It isn't necessary, but we could use a ternary operator here:

task_dict["is_complete"] = True if self.completed_at else False

or the bool function:

task_dict["is_complete"] = bool(self.completed_at)

kelsey-steven-ada · 2022-05-19T03:32:08Z

app/task_routes.py

@@ -0,0 +1,101 @@
+from flask import Blueprint, request, jsonify, make_response, abort


The feedback about abort in goal_routes.py applies here as well.

kelsey-steven-ada · 2022-05-19T03:34:17Z

app/task_routes.py

+    db.session.delete(task)
+    db.session.commit()
+
+    return make_response({"details": f'Task {task_id} "{task.title}" successfully deleted'})


Nice, I like the informative messages.

kelsey-steven-ada · 2022-05-19T21:20:41Z

tests/test_wave_01.py


    # Assert
    assert response.status_code == 404
+    assert response_body == {"details": f"Task #1 not found"}


To ensure we're checking all the relevant data, it might be good to confirm that the database has no records, or that there is no record in the DB with an ID of 1. (This feedback around checking the DB applies to other tests as well.)

kelsey-steven-ada · 2022-05-19T22:28:03Z

tests/test_wave_05.py

-    # assertion 2 goes here
-    # assertion 3 goes here
+    assert response.status_code == 200
+    assert "goal" in response_body


Since we check the whole structure of response_body on the line below which confirms that goal is in the response, we could omit this specific check for goal in response_body.

kelsey-steven-ada · 2022-05-19T22:28:13Z

tests/test_wave_05.py

+            "title": "Updated Goal Title"
+        }
+    }
+    assert goal.title == "Updated Goal Title"


Nice checking the DB contents!

tiffinihyatt added 30 commits May 5, 2022 16:30

Completed setup

b2e3e83

Created Task model

9cf350e

Registered tasks_bp in __init__ file

f01c1f8

Created create_task POST endpoint

04dcaea

Added to_dict method to Task model, passed wave 01

484a576

Created get_all_tasks GET endpoint

0007e84

Created validate_task helper function

b632bf4

Created get_one_task_by_id GET endpoint

b88cb51

Created update_one_task_by_id PUT endpoint

bd1ec2f

Created delete_task_by_id DELETE endpoint

faa3165

Refactored create_task endpoint to handle missing title or description

cb32cc1

Refactored validate_task helper function for consistent error messaging

c84d03c

Adds ascending alphabetical sorting to get_all_tasks endpoint.

0a6acc2

Adds descending alphabetical sorting to get_all_tasks endpoint, passe…

3d21994

…s wave 02

Refactors Task model to_dict() method

a43cd60

Creates mark_task_complete endpoint

97b9776

Creates mark_task_incomplete endpoint

3ce71c2

Refactors create_task endpoint to allow for completion functionality

9054dc1

Refactors update_one_task_by_id endpoint to allow for completion func…

f3844c6

…tionality, passes wave 03

Refactors create_task and update_one_task_by_id endpoints (in progress)

bd3256f

Refactors create_task endpoint to check for completed_at value, passe…

58d7595

…s waves 1-3

Creates post_slack_completion_message helper function, passes wave 04

8765a46

Create Goal model

9fc8fa9

Separate route files into goal_routes.py and task_routes.py

27ccc02

Create goals bp, register in __init__ file

f831a72

Create to_dict() method for Goal model

e166d4a

Add create_goal endpoint

3ea0767

Add get_all_goals() endpoint

0309358

Create validate_goal helper function

ed07c6e

Create get_goal_by_id endpoint

98512a1

tiffinihyatt added 19 commits May 12, 2022 21:32

Create update_goal endpoint

51753f6

Refactor update_goal endpoint to upgrade db

8e08494

Create delete_goal() endpoint

8fe168f

Refactor create_goal() endpoint to handle empty request body, pass wa…

b2cafb6

…ve 05

Create one-to-many relationship between goals and tasks

d4bac3f

Fix foreign key attribute error in Task model

7c6e7e4

Create get_tasks_for_goal endpoint

ab086d2

Create post_tasks_to_goal endpoint

b2a26e4

Pass all tests

f58e31b

Add Procfile for Heroku deployment

d91c67a

Add slack-sdk to project requirements

0a6677e

Add error_message helper function in route_helpers file

bc3e7a1

Refactor endpoints to use error_message() helper function

864a25a

Create validate_model_instance() helper function

147170a

Refactor task_routes.py to use helper functions

4fe80da

Refactor goal_routes.py to use helper function

16ba613

Refactor post_slack_completion_message helper function

bac6ee6

Remove unused imports

06401c4

Refactor Goal to_dict method to include associated task ids

3d942c0

kelsey-steven-ada reviewed May 19, 2022

View reviewed changes

		@@ -0,0 +1,90 @@
		from flask import Blueprint, request, jsonify, make_response, abort

		if self.tasks:
		goal_dict["tasks"] = [task.task_id for task in self.tasks]

		@@ -0,0 +1,101 @@
		from flask import Blueprint, request, jsonify, make_response, abort

Conversation

tiffinihyatt commented May 13, 2022

Uh oh!

kelsey-steven-ada left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kelsey-steven-ada left a comment •

edited

Loading