Draft
Conversation
…dapters into dev/test-refactoring
- reorder directory structure to separate testing models and adapter methods (needs further refactoring for separating tests that are extecuted for each model vs tests that are just run once) - remove all model tests except albert for now (will be readded once final design is agreed on) - refactor albert adapter test class to group test mixins in categories which are then displayed accordingly by test viewer - adjust imports to reflect new directory structure
- refactor generate_test into base test class and adapt parallel generate test accordingly - refactor lm head selection into own method - create utils file for utility methods and adapt imports accordingly - remove is_speech_model flags - replace redundant attributes and methods - enforce proper method naming conventions
This reverts commit b390d61.
- Re-add bart adapter method tests - Remove duplicate added tests - In conversion test refactor model specific if else statements into model test class
3 tasks
- Remove ConditionalGenerationMixin for now - Remove decoderlayermxin from mixin_mapping - Add DecoderLayerWithAdapters for bottleneck support - Fix input shape typo in test config - make style & make quality - Next: Find out why output is the same when using bottleneck adapters and when not
- Add post_embedding_forward hook logic and hook registration to the text model - Without it invertible adapters are not invoked although added to the model
- With MllamaCrossAttentionDecoderLayerWithAdapters the normal crossattentionlayer is replaced during adapters.init() and adds the adapters logic - Also redundant mixins are removed form the model_mixin_mapping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adresses #773 and adds support for the multimodal LLama 3.2 models. (WIP)