Skip to content

Fix: exclude non-trackable models from checkCompletionStatusFor #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
danielghost wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: exclude non-trackable models from checkCompletionStatusFor #532

danielghost wants to merge 1 commit into from

Conversation

@danielghost
Copy link
Contributor

@danielghost danielghost commented May 3, 2024

Fixes #526.

Fix

  • Exclude non-trackable models from checkCompletionStatusFor.

New

  • Added getAvailableTrackableChildModels to return only _isAvailable: true and _isTrackable !== false models.

@danielghost danielghost added the bug label May 3, 2024
@danielghost danielghost self-assigned this May 3, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@cahirodoherty-learningpool cahirodoherty-learningpool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster
Copy link
Member

oliverfoster commented Jun 2, 2024 •
edited
Loading

_isTrackable should not be intertwined with completion or optionality, please fix this in trickle rather than core.

Whether something is saved to the lms or not has nothing to do with whether it's complete or optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@ethan-lp ethan-lp ethan-lp approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@lemmyadams lemmyadams lemmyadams approved these changes

Assignees

@danielghost danielghost

Labels

bug

Projects

adapt_framework: The TODO Board
Status: Assigned

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

checkCompletionStatusFor doesn't complete if model and its children are optional and trickled

7 participants

@danielghost @oliverfoster @cahirodoherty-learningpool @ethan-lp @joe-allen-89 @lemmyadams