Add support for creating workers#2
Open
rajit wants to merge 3 commits intoadcloud:masterfrom
fid-dev:master
Open
Add support for creating workers#2rajit wants to merge 3 commits intoadcloud:masterfrom fid-dev:master
rajit wants to merge 3 commits intoadcloud:masterfrom
fid-dev:master
Conversation
- try reauthentication if cloud control responses with "Unauthorized"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST requests were passing parameters in the URL, which cloudcontrol does not support.
This patch checks if the request is a POST and then creates a curl command to add the parameters to the POST data instead.
There is no sanitisation of input or escaping, so probably fragile right now.