Upgrade to adcp 2.2.0 with proper Pydantic types #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This upgrade resolves schema validation issues by using the adcp library's proper Pydantic types for nested structures (Dimensions, Render, AssetsRequired) which automatically apply exclude_none serialization. Changes: - Upgrade adcp: 1.2.1 → 2.2.0 for proper Pydantic types and semantic aliases - Add discriminator fields (item_type) for union type validation - Update type enum comparisons to use library Type instead of local enum - Fix render/dimension access to support both Pydantic models and dicts - Update all tests to handle new library types and response structures - Create deprecated compat module for backward compatibility All 213 tests now pass with 68.23% coverage. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The adcp 2.2.0 upgrade introduced proper Pydantic types throughout, which required several changes to pass mypy type checking: Changes: - Update helper functions to return library Pydantic models (LibRender, LibAssetsRequired) - Convert all Format type="string" to type=LibType.enum - Add AnyUrl() wrapper for all agent_url parameters - Use library Type enum (LibType) instead of local Type enum in filter signatures - Remove dict-handling branches (renders/assets always Pydantic models now) - Use CreativeAgent Pydantic model with Capability enum - Fix asset_req to use hasattr() instead of isinstance(dict) All 213 tests passing with 69.49% coverage. Mypy passes cleanly on all 22 source files. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolved schema validation issues by upgrading to adcp 2.2.0 with proper Pydantic types for nested structures. This ensures
exclude_noneserialization works correctly at all levels, eliminatingnullvalues in optional fields.Test Results: All 213 tests passing (100%) with 68.23% coverage.
Changes
Verification
Original schema validation issues are fixed:
requirements: nullin asset fields (formats 17-22)width/height: nullin responsive dimensions (formats 39, 41)