fix: enforce tenant human_review_required for media buy approval #866
+139
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tenant's human_review_required setting was not being enforced during media buy creation. The code was only checking the adapter's manual_approval_required setting, which could be out of sync with the tenant configuration. This fix: - Uses tenant.human_review_required as the authoritative source - Falls back to adapter setting if tenant allows auto-approval - Adds debug logging for both settings to aid troubleshooting - Adds tests to verify the enforcement logic Also updates type-ignore baseline which was out of sync with main branch. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…cution These tests need media buy creation to execute immediately (not go to approval workflow) to properly test pricing validation and response fields. The fix for issue #845 changed the default behavior to require approval, which caused these tests to fail because they expected immediate execution to validate error responses and field presence. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
When using ToolContext (from A2A or direct tool calls), the tenant
context was only being set with {"tenant_id": ...} instead of loading
the full tenant record from the database. This caused the
human_review_required field to be missing, defaulting to True.
Now the context helper attempts to load the full tenant from the
database to get all fields. Falls back to minimal tenant dict if
database is unavailable (e.g., in unit tests).
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ture The test fixture was missing human_review_required=False, causing the media buy creation to go through the approval workflow instead of executing immediately, which led to database constraint violations. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Use specific exceptions (SQLAlchemyError, RuntimeError) instead of bare Exception in context_helpers.py - Refactor test_tenant_manual_approval_enforcement.py with cleaner structure and better docstrings explaining the test strategy 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This was referenced Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
human_review_requiredsetting was not being enforced during media buy creationmanual_approval_requiredsetting, which could diverge from tenant configurationhuman_review_requiredas the authoritative source with adapter setting as fallbackTest plan
Closes #845
🤖 Generated with Claude Code