[FIX] oauth_provider: keep tuple

[augusto-weiss]

No description provided.

[Copilot]

Pull request overview

This pull request attempts to modify the OAuth provider scope data handling by keeping tuple values for many2one fields instead of extracting just the name component. However, this change introduces a critical bug that will cause runtime failures.

Changes:

• Modified _get_data_for_model method to return full tuple values for many2one fields instead of extracting the name
• Commented out the previous implementation that extracted the name from tuples
• Added a comment explaining the intent to keep tuple values

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Commented-out code should be removed entirely rather than left in the codebase. If the old implementation needs to be referenced, it can be retrieved from version control history.

Suggested change

	# if isinstance(value, tuple):
	# # Return only the name for a many2one
	# data[record_data["id"]][field] = value[1]
	# else:
	# data[record_data["id"]][field] = value

[Copilot]

This change will cause a critical bug. The data returned by this method is serialized to JSON in the controller using json.dumps() (see ir_http.py:45). Python tuples are not JSON serializable, which will cause a TypeError at runtime when many2one fields are included in the response.

Additionally, this is a breaking API change. The existing tests expect many2one fields to return just the name string (see test_oauth_provider_scope.py:222 which expects "country_id": country.name), not a tuple.

The previous behavior of extracting only the name from the tuple was correct and should be kept.

Suggested change

	# m2o filds return a tuple (id, name), now we want keep it
	data[record_data["id"]][field] = value
	# if isinstance(value, tuple):
	# # Return only the name for a many2one
	# data[record_data["id"]][field] = value[1]
	# else:
	# data[record_data["id"]][field] = value
	# m2o fields return a tuple (id, name); return only the name
	if isinstance(value, tuple):
	# Return only the name for a many2one
	data[record_data["id"]][field] = value[1]
	else:
	data[record_data["id"]][field] = value

[Copilot]

Spelling error: "filds" should be "fields".

Suggested change

	# m2o filds return a tuple (id, name), now we want keep it
	# m2o fields return a tuple (id, name), now we want keep it