Skip to content

Forms 12668 #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajatofficial wants to merge 5 commits into
base: dev
Choose a base branch
from
+7 −0
Open

Forms 12668 #1044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a79fb06
panel container placeholder text added
rajatkhurana-adobe Jan 23, 2024
dcc14d7
panel component placeholder test case added
rajatkhurana-adobe Jan 23, 2024
f5fc712
only removed from tc
rajatkhurana-adobe Jan 24, 2024
5300917
panel container placeholder text added
rajatkhurana-adobe Jan 23, 2024
da567c6
panel component placeholder test case added
rajatkhurana-adobe Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...cr_root/apps/core/fd/components/form/panelcontainer/v1/panelcontainer/responsiveGrid.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
data-cmp-readonly="${panel.readOnly ? 'true' : 'false'}"
title="${panel.tooltipVisible ? '' : panel.tooltipText}"
role="${container.roleAttribute}"
data-placeholder-text="${'Please drag Panel components here' @ i18n}"
style="${container.backgroundStyle @ context='styleString'}">
<div class="cmp-container__label-container" role="heading">
<div data-sly-call="${label.label @componentId=panel.id, labelValue=panel.label.value, labelVisible=panel.label.visible, labelRichText=panel.label.richText, bemBlock='cmp-container'}" data-sly-unwrap></div>
Expand Down
1 change: 1 addition & 0 deletions ...ontent/jcr_root/apps/core/fd/components/form/panelcontainer/v1/panelcontainer/simple.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
class="cmp-container${wcmmode.edit ? ' {0}': '' @ format=[allowed.cssClass]}"
title="${panel.tooltipVisible ? '' : panel.tooltipText}"
role="${container.roleAttribute}"
data-placeholder-text="${'Please drag Panel components here' @ i18n}"
style="${container.backgroundStyle @ context='styleString'}">
<div class="cmp-container__label-container">
<div data-sly-call="${label.label @componentId=panel.id, labelValue=panel.label.value, labelVisible=panel.label.visible, labelRichText=panel.label.richText, bemBlock='cmp-container', isHeading=true}" data-sly-unwrap></div>
Expand Down
5 changes: 5 additions & 0 deletions ui.tests/test-module/specs/panelcontainer/panelcontainer.authoring.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,11 @@ describe('Page - Authoring', function () {
cy.deleteComponentByPath(panelEditPath);
});

it('Check placeholder text in Panel ', function () {
dropPanelInContainer();
cy.get(panelContainerPathSelector).get("[data-text='Please drag Panel components here']").should("exist");;
});

it('open edit dialog of Panel', function () {
testPanelBehaviour(panelContainerPathSelector, panelEditPath);
})
Expand Down