-
Notifications
You must be signed in to change notification settings - Fork 65
Feat: added the loader to avoid multiple submits and tests #1713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c221209 to
5e37881
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Accessibility Violations Found
|
6 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
Accessibility Violations Found
|
...tent/jcr_root/apps/core/fd/components/form/button/v1/button/clientlibs/site/js/buttonview.js
Outdated
Show resolved
Hide resolved
c6d102d to
e126c01
Compare
...ps/src/main/content/jcr_root/apps/core/fd/components/form/actions/submit/v1/submit/README.md
Outdated
Show resolved
Hide resolved
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
Accessibility Violations Found
|
rismehta
reviewed
Sep 16, 2025
...tent/jcr_root/apps/core/fd/components/form/button/v1/button/clientlibs/site/js/buttonview.js
Show resolved
Hide resolved
rismehta
requested changes
Sep 17, 2025
Collaborator
rismehta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check comments
8084d2e to
cce6af5
Compare
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
rismehta
reviewed
Sep 23, 2025
...tent/jcr_root/apps/core/fd/components/form/button/v1/button/clientlibs/site/js/buttonview.js
Show resolved
Hide resolved
…eck for loader class
bab8b76 to
c504f12
Compare
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
rismehta
added a commit
that referenced
this pull request
Oct 8, 2025
* FORMS-21799 fixing aria-label to display plain text (#1715) * FORMS-21799 fixing aria-label to display plain text * FORMS-21799 correcting naming convention * FORMS-21799 adding tests * FORMS-21799 increasing test coverage * FORMS-21799 increasing test coverage --------- Co-authored-by: Shivam Agarwal <shivama@adobe.com> * Merge pull request #1713 from adobe/FORMS-21742 Feat: added the loader to avoid multiple submits and tests * Fixing js doc (#1721) * @releng updating af-core (#1726) * @releng updating af-core * @releng updating af-core --------- Co-authored-by: Shivam Agarwal <47965724+im-shiv@users.noreply.github.com> Co-authored-by: Shivam Agarwal <shivama@adobe.com> Co-authored-by: armaang1729 <armaang@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added loader to prevent multiple form submits
Description
This PR addresses Issue #1215, which reported that clicking the Submit button multiple times triggered multiple form submissions, resulting in duplicate entries.
To resolve this, a loader has been introduced that appears on form submission. While the loader is active, the form is disabled, preventing duplicate submits until the process is complete.
Related Issue
Motivation and Context
Multiple submissions from repeated clicks on the Submit button were leading to duplicate form entries, which negatively impacted both user experience and backend data integrity.
By introducing a loader that disables the form during submission, this fix ensures that only one submission is processed at a time.
How Has This Been Tested?
Types of changes
Checklist