Updating input components' validation field to reflect existing pattern #1785
Conversation
| if (formatComponent && !formatComponent.closest("div").hasAttribute("hidden") && displayPatternSelectedValue!="custom") { | ||
| formatComponent.value = patternComponent.value; | ||
| // Preserve a previously saved pattern (when no dropdown options are present) | ||
| formatComponent.value = formatComponent.value || patternComponent.value; |
There was a problem hiding this comment.
does this also impact other components? was custom format working correctly for other components custom format?
There was a problem hiding this comment.
This method is consumed by multiple components (textinput, telephoneinput, numberinput and datepicker) - i have tested all the components with the change added in new commit, no current functionality is broken.
muskgupta
changed the title
| // Only update format component value if it exists and is not hidden | ||
| if (formatComponent && !formatComponent.closest("div").hasAttribute("hidden") && displayPatternSelectedValue!="custom") { | ||
| formatComponent.value = patternComponent.value; | ||
| // Only update format component value if it exists and is not hidden |
There was a problem hiding this comment.
We will update the pattern value from dropdown only in cases where dropdown is visible. Earlier it was updating even on manual pattern entry where the dropdown was not visible and the pattern dropdown had value "" which was rewriting the entered format value from showing up subsequently in the dialog.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
muskgupta
force-pushed
the
SuncorpBugFix
branch
from
d0fcc65 to
c93234a
Compare
Description
Updating textinput core component's validation field to reflect existing pattern if entered.
Customer : Suncorp
Related Issue
E-001967925
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: