TNC component #124
TNC component #124
Conversation
| name={name} | ||
| readOnly={readOnly} | ||
| disabled={!enabled} | ||
| disabled={context.disabled} |
There was a problem hiding this comment.
What if checkbox is rendered without TnC?
There was a problem hiding this comment.
Removed this logic and implemented it via model, fetching the model of checkbox and enabling it after scroll.
| appliedCssClassNames, | ||
| readOnly | ||
| } = props; | ||
| const options = enumNames && enumNames.length ? enumNames : enums || []; |
There was a problem hiding this comment.
Why does link component have checkbox group, its not clear ?
|
|
||
| return ( | ||
| <div | ||
| className={`cmp-adaptiveform-checkboxgroup cmp-adaptiveform-checkboxgroup--${ |
There was a problem hiding this comment.
Why are we not re-using the existing checkbox group component ?
There was a problem hiding this comment.
@rismehta, the bem is different when compared to checkbox group component as it contains the anchor tag so that one can visit the link in order to enable the checkbox. The same approach has been used in core component as well.
There was a problem hiding this comment.
I don't see the BEM different, can you point out the differences ? For core components, re-usability was not trivial, thats why we did not re-use the components. But in react, you should be able to re-use, if there are differences expose them as props.
There was a problem hiding this comment.
Implemented, re-used the checkbox group component!
| key={enums![index]} | ||
| > | ||
| <label className="cmp-adaptiveform-checkboxgroup__option-label"> | ||
| <a |
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: