Skip to content

Conversation

@CezarSTF
Copy link
Collaborator

@CezarSTF CezarSTF commented Apr 7, 2025

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@vaibhav2601 vaibhav2601 requested a review from akshayvas April 8, 2025 08:06
&__errormessage {
display: none;
color: $error;
color: $error-darker;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CezarSTF There is an existing $dark-error token also being used in few states like hover.
Please check once if the appearance is fine, and if the contrast works fine for those states too.
cc: @vaibhav2601

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshayvas because $dark-error is rgba(255,57,50,0.148), the contrast ratio will be 1.2:1.
I used a new variable (error-darker) to match the required contrast ratio (4.5:1)

@CezarSTF
Copy link
Collaborator Author

Closing this PR because I will create another one, straight from the main repo.

@CezarSTF CezarSTF closed this May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants