Skip to content

Conversation

@stefan-dragomir
Copy link
Collaborator

@stefan-dragomir stefan-dragomir commented Apr 16, 2025

Description

Related Issue

https://jira.corp.adobe.com/browse/FORMS-18740

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.


&--active {
color: $accent;
color: $black;
Copy link
Contributor

@akshayvas akshayvas Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefan-dragomir instead of black, we should check if another shade of same color can be used to fix contrast. if not possible, then confirm with XD once

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black was the designer's suggestion to make the tab color more striking since we can't change the tab's background color.
Also moving this to a PR raised from Main instead of Fork. #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants