FORMS-18734: Text content lacks 4.5:1 contrast ratio @sunnym @vavarshn #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshayvas
reviewed
May 26, 2025
src/site/_mixin.scss
Outdated
| &[data-cmp-valid=false]>&__label-container>&__label { | ||
| font-weight: 500; | ||
| color: $error ; | ||
| color: $error-darker ; |
Contributor
There was a problem hiding this comment.
@CezarSTF The changes seem fine. But please check if the contrast issue is valid for other fields also. These changes will apply to all fields, and ideally the issue should have been there for all fields, and not just field attachment. In case, issue is in all fields, we can update the JIRA description to reflect the same.
Collaborator
Author
There was a problem hiding this comment.
Okay, I'll take a look over all the affected fields.
Collaborator
Author
There was a problem hiding this comment.
Please check again
akshayvas
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: