Skip to content

Conversation

@brenthosie
Copy link
Member

Resolves #28

Description

jwt-auth is now providing a lot more useful information about why the token exchange fails. We can now observe that information and display it to the user.

Related Issue

https://jira.corp.adobe.com/browse/PDCL-4946

Motivation and Context

Users didn't understand in many scenarios why they were unable to get an access token.

How Has This Been Tested?

  1. Manual test of uploader
  2. npm test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@brenthosie
Copy link
Member Author

Relies on adobe/jwt-auth#53

@brenthosie brenthosie marked this pull request as ready for review April 23, 2021 20:34
@brenthosie brenthosie merged commit 9acfe79 into master Apr 23, 2021
@brenthosie brenthosie deleted the PDCL-4946-consume-better-jwt-errors branch April 23, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error retrieving access token. undefined

2 participants